[gstreamer-bugs] [Bug 599027] New: [PATCH] Call unlink_streams in client_finalize

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=599027
  GStreamer | gst-rtsp-server | git

           Summary: [PATCH] Call unlink_streams in client_finalize
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: luca.ognibene at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Sometime i get this segfault when a client connected to gst-rtsp-server
segfaults:
[20/10/2009 10:44:56.478956]: client 0x84dae90: received an error System error:
Connection reset by peer
[20/10/2009 10:44:56.479083]: finalize client 0x84dae90

GLib-CRITICAL **: g_async_queue_push: assertion `queue' failed
aborting...

#0  0xb7f1a430 in __kernel_vsyscall ()
#1  0xb78cd6d0 in *__GI_raise (sig=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0xb78cf098 in *__GI_abort () at abort.c:88
#3  0xb7e58eac in IA__g_logv (log_domain=0xb7e88f06 "GLib",
log_level=G_LOG_LEVEL_CRITICAL, format=0xb7e90bf1 "%s: assertion `%s' failed", 
    args1=0xb2ef910c "�\223��\032\221��") at
/build/buildd/glib2.0-2.20.1/glib/gmessages.c:506
#4  0xb7e58ee6 in IA__g_log (log_domain=0xb7e88f06 "GLib",
log_level=G_LOG_LEVEL_CRITICAL, format=0xb7e90bf1 "%s: assertion `%s' failed")
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c:526
#5  0xb7e5914b in IA__g_return_if_fail_warning (log_domain=0xb7e88f06 "GLib",
pretty_function=0xb7e893e4 "g_async_queue_push", 
    expression=0xb7e8911a "queue") at
/build/buildd/glib2.0-2.20.1/glib/gmessages.c:541
#6  0xb7e2891a in IA__g_async_queue_push (queue=0x0, data=0xb5711890) at
/build/buildd/glib2.0-2.20.1/glib/gasyncqueue.c:223
#7  0xb76e8a2e in gst_rtsp_watch_queue_data (watch=0x84d1840, data=0xb57120b0
"$", size=1456) at gstrtspconnection.c:3023
#8  0xb76e8af3 in gst_rtsp_watch_queue_message (watch=0x84d1840,
message=0xb2ef91a8) at gstrtspconnection.c:3065
#9  0xb7b7f472 in do_send_data (buffer=0x8525868, channel=<value optimized
out>, client=0x84dae90) at rtsp-client.c:310
#10 0xb7b81928 in handle_new_buffer (sink=0x8506018, user_data=0x84eeb90) at
rtsp-media.c:908
#11 0xb76d5f23 in gst_app_sink_render_common (psink=<value optimized out>,
data=0x8525868, is_list=0) at gstappsink.c:759

I think the problem is that client_finalize is not calling unlink_streams. I'm
attaching a patch that works for me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.