[gstreamer-bugs] [Bug 598896] [GstRegistry] Cache lists of ElementFactory and TypeFindFactory

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=598896
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145923|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2009-10-22 08:53:16 UTC ---
Review of attachment 145923:
 --> (https://bugzilla.gnome.org/review?bug=598896&attachment=145923)

- Use g_list_alloc() instead of GSlice, you never know if GLib will change
allocations of list nodes again in the future
- You could use g_list_append() instead of the manual twiddling with the next
and prev pointers... unless the function call is too expensive for you :)
g_list_append() runs in O(1) if you append a new node to the last element btw
but you know that ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.