[gstreamer-bugs] [Bug 599105] [baseaudiosink] Remove pulsesink < 0.10.17 hack after gst-plugins-good release

Thu Oct 22 06:47:13 PDT 2009

https://bugzilla.gnome.org/show_bug.cgi?id=599105
  GStreamer | gst-plugins-base | unspecified

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com

--- Comment #10 from Jan Schmidt <thaytan at mad.scientist.com> 2009-10-22 13:47:07 UTC ---
(In reply to comment #9)
> > But let's move this to gst-plugins-base and mark it as blocker for 0.10.26 to
> > make sure that the pulsesink hack gets removed after gst-plugins-good 0.10.17
> > was released.
> 
> I'm not sure if we can really do this. Shouldn't it be possible to drop in a
> core/base 0.10.26/27/28 with an older gst-plugins-good?

Yes - the intention was that the 'hack' would stick around until 1.0.

> Also, in retrospect I think maybe we should have worked around this
> differently, by making pulsesink use g_object_set_user_data(pulsesink,
> "skip-timestamp-offsetting", GINT_TO_POINTER(1)) or something like that, but I
> guess there's not much reason to change that now.

You're right - that's a nicer way to handle this stuff in the future.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.