[gstreamer-bugs] [Bug 600269] New: Gstreamer's Queue will leak Events in LEAK_DOWNSTREAM mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=600269
  GStreamer | gstreamer (core) | 0.10.x

           Summary: Gstreamer's Queue will leak Events in LEAK_DOWNSTREAM
                    mode
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: bens at alum.mit.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


While perusing the source code of Queue, I noticed that leak_downstream()
appears to leak Buffers and Events:

http://cgit.freedesktop.org/gstreamer/gstreamer/tree/plugins/elements/gstqueue.c#n884

Notice that the value of is_buffer is never checked, so Events could easily be
dequeued.  However, I have been told that even a leaking Queue should never
lose an Event.

Either the code is incorrect, the documentation is misleading, or I am just not
understanding the situation.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.