[gstreamer-bugs] [Bug 615783] reworked timestamping in adder
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Apr 16 11:38:09 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=615783
GStreamer | gst-plugins-base | git
--- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-04-16 18:38:06 UTC ---
(In reply to comment #1)
> Review of attachment 158756 [details]:
>
> Looks good in general but
>
> ::: gst/adder/gstadder.c
> @@ +728,2 @@
> else
> + adder->segment_start = 0;
>
> You should probably either refuse seeks with a different type or correctly
> handle them instead of just doing a [0,-1] seek :)
-1 is open end. We should probably reject GST_SEEK_TYPE_CUR and
GST_SEEK_TYPE_END like everywhere else. Is it that what you mean?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list