[gstreamer-bugs] [Bug 614305] [PLUGIN-MOVE] oss4 should be moved to good

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=614305
  GStreamer | gst-plugins-bad | 0.10.18

--- Comment #8 from Brian Cameron <brian.cameron at oracle.com> 2010-04-16 21:10:43 UTC ---
Created an attachment (id=158922)
 View: https://bugzilla.gnome.org/attachment.cgi?id=158922
 Review: https://bugzilla.gnome.org/review?bug=614305&attachment=158922

patch implementing GstStreamVolume

Here is a patch that implements the GstStreamVolume interface for the OSSv4
plugin.  Based on my testing it seems to work well.  I do see that the
properties are being used to get and set the volume properly when using the
plugin built with this patch.  With this patch, can the OSSv4 plugin be moved
to gst-plugins-good?

---

One thing I don't like about using the GstStreamVolume interface is that when
using the OSSv4 plugin with this change, the volume decreases much more rapidly
when I move the volume slider down in programs like totem or rhythmbox.  From
looking at the code in a debugger, I can see the values go down quickly because
of the conversion to/from "GST_STREAM_VOLUME_FORMAT_CUBIC" which is used by 
totem & rhythmbox.

Since the volume slider doesn't decrease volume so much when you slide it down
before the OSSv4 plugin implemented this interface, I assume that the
GST_STREAM_VOLUME_FORMAT_CUBIC was being ignored before.

But if the GStreamer community feels that it is better for the volume to
decrease rapidly like this, then I guess this isn't a problem.  I notice that
the gst-plugins-base documentation recommends that GUI's use CUBIC.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.