[gstreamer-bugs] [Bug 614305] [PLUGIN-MOVE] oss4 should be moved to good

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=614305
  GStreamer | gst-plugins-bad | 0.10.18

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-04-17 08:59:13 UTC ---
Ah, yes (hadn't looked at the patch yet).

Some more comments on the patch:

 - the SET/GET ioctls should be moved into a
   helper function

 - we probably need to add a lock to make
   sure the SET/GET volume ioctls are not
   called at the same time (from the application
   thread) as the SNDCTL_DSP_GETODELAY ioctl
   (which would be called from the streaming
   thread), since last time I checked OSS4 didn't
   handle ioctls on the same fd from multiple
   threads very well (understatement).

 - I think the stream volume should be stored
   as a single mono volume value internally,
   you can then construct the VOL | (VOL << 8)
   thing later for the ioctl if needed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.