[gstreamer-bugs] [Bug 600195] dynamic fragment shader filter and variables parser/loader

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=600195
  GStreamer | gst-plugins-gl | git

--- Comment #9 from Luc <luc.deschenaux at freesurf.ch> 2010-04-24 07:40:14 UTC ---
> --- Comment #8 from Filippo Argiolas <fargiolas at gnome.org> 2010-04-23 09:29:16 UTC ---
> I'm willing to move shaders into single files and load them at run time.
> I looked for the 3dlabs parser mentioned above
> (http://3dshaders.com/home/index.php?option=com_weblinks&catid=13&Itemid=33)
> and seems quite simple to me. It just load files into a string with no
> validation nor uniform loading.

Why do you need a parser to load files without validation nor uniform
loading ? open() and read() do the same job.

> Luc any news about the cleaner patch?

I'm in Thailand since a few months, i just started to update my gstreamer
and gst-plugins-gl sources the other day because i need to finish Kifu.
But I'm in holidays and payed work allowing me to stay longer is my
priority.  

> I still think the code in your patch is unnecessarily complicated:

The parser is not a patch it is a new feature , only the glue code is; and the
glue code is simple.

It is not because you dont need to do what's described in the two firsts
paragraphs of comment #6, that the parser is unnecessary. Say you dont need it
here and now.

The parser is not so complicated (although the source is not yet
documented), it just parse a string for uniform variables declarations and
initialisation values and passes them to the shader.

>  as bugfree as it can be, it is difficult to read and
> understand.

It is undocumented low-level code, so yes it takes time and energy to read and
understand it with a brute approach.

To understand the easy way, i suggest you to write a test application calling
gst_gl_shadervariables_parse(0,"uniform int test=(int)10;",0) from
gstglshadervariables.c and use a debugger and 'step into' to see what happends.

Maybe I'm gonna add comments so that you just feel better and waste less time
and energy while trying to understand something you dont need to.. (but is it
really necessary to waste OUR time and energy before theres a real need ?)

I feel like i'm wasting time and energy here and now :)

Regards from the kingdom of smile,

:7üC:

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.