[gstreamer-bugs] [Bug 625944] New GstDiscoverer helper library

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=625944
  GStreamer | gst-plugins-base | git

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-03 18:22:16 UTC ---
(In reply to comment #5)

> > @@ +233,3 @@
> > +  /* This is ugly. We get the GType of decodebin2 so we can quickly detect
> > +   * when a decodebin2 is added to uridecodebin so we can set the
> > +   * post-stream-topology setting to TRUE */
> > 
> > This can be removed, everywhere else too
> 
>   what exactly can be removed ?

The decodebin2 special handling for older versions.

> > 
> > @@ +1100,3 @@
> > +  discoverer->async = TRUE;
> > +  /* Connect to bus signals */
> > +  gst_bus_add_signal_watch (discoverer->bus);
> > 
> > Of course this needs a main loop in the default main context. This should be
> > documented and maybe get an optional GMainContext* parameter
> 
>   It is documented in the discoverer docs that using the async API requires a
> running mainloop (see top of the file).

Oh, right. But please add a parameter to use a non-default main context. Then
it's possible to run it in another thread with a main loop ;)

The GstBus unit test has an example how to get signal watches for a non-default
main context btw...

> > ::: gst-libs/gst/discoverer/gstdiscoverer.h
> > @@ +62,3 @@
> > + */
> > +struct _GstStreamInformation {
> > +  GstStreamType         streamtype;
> > 
> > Maybe this should be a GstMiniObject. The inheritance of the structs might be
> > complicated for bindings
> 
>   Switching to GstMiniObject wouldn't help that much, we'd still end up with
> the inheritance problem. The only thing that could make it a *bit* better for
> bindings would be to not inherit and just copy all fields from the parent
> struct over to those *sub*structures.

Well, for GstMiniObject bindings already have the required magic... for new
stuff they don't. Is there any reason not to use GstMiniObject? :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.