[gstreamer-bugs] [Bug 624338] [pulsesink] double-free exception

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Aug 4 08:41:35 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=624338
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-04 15:41:32 UTC ---
Committed this, but changed the commit message:

 commit 864a52d8aa938fbc308a5bf027cbc4bd8a23d45e
 Author: Philippe Normand <pnormand at igalia.com>
 Date:   Thu Jul 15 10:10:31 2010 +0200

    pulsesink: use G_TYPE_DEFINE to define ring buffer type

    The existing get_type() implementation is racy, and the
    g_type_class_ref() workaround didn't actually work because
    it was in the wrong function. Since class creation in GObject
    is thread-safe these days (since 2.16), the class_ref workaround
    is no longer needed and it is sufficient to ensure the _get_type()
    function is thread-safe, which G_TYPE_DEFINE does.

    https://bugzilla.gnome.org/show_bug.cgi?id=624338


The only reason this is actually ok as-is is that now class creation in gobject
is thread-safe, which wasn't the case when the g_type_class_ref() was added
(IIRC) ;-)

Setting NEEDINFO for answer to comment #10, although the stack trace looks like
there is something else going on.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list