[gstreamer-bugs] [Bug 574290] [dshowvideosink] make set_xwindow_id() in PLAYING state work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=574290
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-06 09:26:17 UTC ---
I'm not sure changing the window ID whilst in playing state is a particularly
thing to do or support, but since it seems this is unlikely to break anything
for people who don't do this, we may just as well commit it I guess. Please
also note IRC comments below re. use of LONG_PTR / LONG etc.


commit c2c32fe773aacfdcf823e6faf4a2327e6f997760
Author: Andoni Morales Alastruey <ylatuya at gmail.com>
Date:   Sun Jul 25 17:04:12 2010 +0200

    dshowvideosink: close our own window when changing the window id

    If we created the window, it needs to be closed after setting a new
    window id.

    https://bugzilla.gnome.org/show_bug.cgi?id=574290

commit 7ab007bafeb5e3b32b0156235f51c1f4b4f442d9
Author: Raimo Jarvi <raimo.jarvi at gmail.com>
Date:   Sun Jul 25 17:01:19 2010 +0200

    dshowvideosink: allow changing window ID whilst in PLAYING state

    https://bugzilla.gnome.org/show_bug.cgi?id=574290



<__tim> MikeS, any comments on
https://bugzilla.gnome.org/show_bug.cgi?id=574290 ?
<MikeS> __tim: it looks vaguely plausible, and doesn't look like it'd break
anything that any sane user would ever do.
<MikeS> (I have no idea why you'd ever want to call that in playing)
...
<Mook_sb> random drive-by comment: please cast to LONG_PTR instead of LONG for
the parameter of SetWindowLongPtr. Also, consider using SetWindowSubclass if
you don't care about pre-XP.
<MikeS> __tim: Mook_sb knows more about win32 than any sane person should; what
he says is probably <__tim> Mook_sb, any chance you could put that into the
bug?
<Mook_sb> no, I just happen to occasionally be inside the crazy intersection of
(gcc) and (win64)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.