[gstreamer-bugs] [Bug 626425] New: cog_virt_frame_new_convert_u8 has bogus source data

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626425
  GStreamer | gst-plugins-bad | git

           Summary: cog_virt_frame_new_convert_u8 has bogus source data
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: jonathan.rosser at rd.bbc.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


cogvirtframe.c:1874 allocates temporary storage that is never filled
cogvirtframe.c:1859 uses this as a source rather than 'src' set on the previous
line

Sorry no gstreamer patch, I have my own private libcog with this applied:


--- a/cog/cogvirtframe.c
+++ b/cog/cogvirtframe.c
@@ -2170,7 +2170,7 @@ convert_u8_s16 (CogFrame * frame, void *_dest, int
component, int i)
   int16_t *src;

   src = cog_virt_frame_get_line (frame->virt_frame1, component, i);
-  orc_convert_u8_s16 (dest, frame->virt_priv,
+  orc_convert_u8_s16 (dest, src,
       frame->components[component].width);
 }

@@ -2185,7 +2185,6 @@ cog_virt_frame_new_convert_u8 (CogFrame * vf)
   virt_frame = cog_frame_new_virtual (vf->domain, format, vf->width,
vf->height);
   virt_frame->virt_frame1 = vf;
   virt_frame->render_line = convert_u8_s16;
-  virt_frame->virt_priv = cog_malloc (sizeof (int16_t) * vf->width);

   return virt_frame;
 }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.