[gstreamer-bugs] [Bug 626621] [playbin2] streamsynchronizer regressions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626621
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167587|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-11 14:07:38 UTC ---
Review of attachment 167587:
 --> (https://bugzilla.gnome.org/review?bug=626621&attachment=167587)

Looks good in general and shouldn't hurt to add these queues

::: gst/playback/gstplaysink.c
@@ +1219,3 @@

+  /* NOTE streamsynchronizer needs streams decoupled */
+  if (TRUE) {

Just remove this large if block here

@@ +1438,3 @@
+          GST_ELEMENT_WARNING (playsink, CORE, MISSING_PLUGIN,
+              (_("Missing element '%s' - check your GStreamer installation."),
+                  "queue"), ("video rendering might be suboptimal"));

vqueue => subqueue or something like that

and The warning talks about video, not text

@@ +1642,3 @@
+  /* NOTE streamsynchronizer always need a queue to decouple its EOS sending
+   * (which might otherwise hang in downstream prerolling on EOS) */
+  if (TRUE) {

Remove the complete if block

@@ +2149,3 @@
+  /* NOTE although there is some nifty heuristic regarding whether or not to
+   * include a queue in some chain, streamsynchronizer mechanics need
+   * subsequent streams decoupled to prevent hangs */

Better remove these heuristics then where necessary, should make some code a
bit easier to understan

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.