[gstreamer-bugs] [Bug 626181] [pbutils] Add enhanced gstfactorylists

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626181
  GStreamer | gst-plugins-base | git

--- Comment #10 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-08-12 15:13:39 UTC ---
Review of attachment 167259:
 --> (https://bugzilla.gnome.org/review?bug=626181&attachment=167259)

::: gst-libs/gst/pbutils/gstfactorylists.c
@@ +71,3 @@
+  const gchar *klass;
+
+  klass = gst_element_factory_get_klass (factory);

what about appending/prepending a '/' and always searching for e.g. "/Sink" or
"Sink/" to match on word boundaries?

@@ +146,3 @@
+ */
+GValueArray *
+gst_factory_list_get_elements (GstFactoryListType type, GstRank minrank)

whats the reason for using GValueArray and not the GList?

@@ +211,3 @@
+ * Merges the content of @array2 into @array1 and frees @array2.
+ * The contents of @array1 will be sorted before returning.
+ */

"... will be sorted by decreasing rank"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.