[gstreamer-bugs] [Bug 626181] [pbutils] Add enhanced gstfactorylists

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626181
  GStreamer | gst-plugins-base | git

--- Comment #12 from Edward Hervey <bilboed at gmail.com> 2010-08-16 10:06:28 UTC ---
(In reply to comment #10)
> Review of attachment 167259 [details]:
> 
> ::: gst-libs/gst/pbutils/gstfactorylists.c
> @@ +71,3 @@
> +  const gchar *klass;
> +
> +  klass = gst_element_factory_get_klass (factory);
> 
> what about appending/prepending a '/' and always searching for e.g. "/Sink" or
> "Sink/" to match on word boundaries?

  Apart from the fact that it would be extra processing for no gain, you'd
still need to do a match for "Sink" for the case where an element only has that
as the klass... and that would make the other checks useless.

> 
> @@ +146,3 @@
> + */
> +GValueArray *
> +gst_factory_list_get_elements (GstFactoryListType type, GstRank minrank)
> 
> whats the reason for using GValueArray and not the GList?

  It was using GValueArray previously, I didn't see any point in switching to a
GList.

> 
> @@ +211,3 @@
> + * Merges the content of @array2 into @array1 and frees @array2.
> + * The contents of @array1 will be sorted before returning.
> + */
> 
> "... will be sorted by decreasing rank"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.