[gstreamer-bugs] [Bug 627229] fpsdisplaysink should not measure fps relative to pipeline clock

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627229
  GStreamer | gst-plugins-bad | git

--- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-08-18 08:05:35 UTC ---
Review of attachment 168169:
 --> (https://bugzilla.gnome.org/review?bug=627229&attachment=168169)

::: gst/debugutils/fpsdisplaysink.c
@@ +225,3 @@
+        self->last_ts = self->start_ts = gst_util_get_timestamp();
+        self->timeout_id =
+            g_timeout_add (self->fps_update_interval, display_current_fps,

Hmm, actually the g_timeout_add() is a problem. It adds a g_main_loop()
dependency :/. But it was there before.

@@ +331,3 @@
+
+  frames_rendered = g_atomic_int_get (&self->frames_rendered);
+  frames_dropped = g_atomic_int_get (&self->frames_dropped);

If we want ultimate consistency we would need a lock instead of the atomics.
Theoretically we can read the first var and then it changes before we read the
2nd. Would that be bad?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.