[gstreamer-bugs] [Bug 626181] [pbutils] Add enhanced gstfactorylists

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626181
  GStreamer | gst-plugins-base | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de

--- Comment #26 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-08-20 19:29:07 UTC ---
(In reply to comment #12)
> (In reply to comment #10)
> > Review of attachment 167259 [details] [details]:
> > 
> > ::: gst-libs/gst/pbutils/gstfactorylists.c
> > @@ +71,3 @@
> > +  const gchar *klass;
> > +
> > +  klass = gst_element_factory_get_klass (factory);
> > 
> > what about appending/prepending a '/' and always searching for e.g. "/Sink" or
> > "Sink/" to match on word boundaries?
> 
>   Apart from the fact that it would be extra processing for no gain, you'd
> still need to do a match for "Sink" for the case where an element only has that
> as the klass... and that would make the other checks useless.

I meant prepending the klass var and the matching with an additional '/'. And
yes it is extra processing, but also some safety. But then, this can also be
done when the first bug pops up. Was just an idea.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.