[gstreamer-bugs] [Bug 628258] [dshowvideosink] Patch for I420 support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=628258
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Andoni Morales <ylatuya at gmail.com> 2010-08-29 23:40:33 UTC ---
Review of attachment 169011:
 --> (https://bugzilla.gnome.org/review?bug=628258&attachment=169011)

::: sys/dshowvideosink/dshowvideofakesrc.cpp
@@ -171,3 +174,3 @@
         srcstride = GST_ROUND_UP_4 ( GST_ROUND_UP_2 (vh->rcSource.right) / 2);
       else {
-        if (component == 1)
+        if (I420) {

In line 160, so should check for YV12 and I420.
Here, check the format using the 'fourcc' variable.

::: sys/dshowvideosink/dshowvideofakesrc.h
@@ +24,3 @@
 #include <gst/gst.h>
+
+bool I420;

The 'subtype' variable should be used here.

::: sys/dshowvideosink/dshowvideosink.cpp
@@ +1433,3 @@
+            "format", GST_TYPE_FOURCC, GST_MAKE_FOURCC ('Y', 'V', '1', '2'),
NULL);
+    caps = gst_caps_new_simple ("video/x-raw-yuv", 
+  else if (IsEqualGUID (mediatype->subtype, MEDIASUBTYPE_I420))

The fourcc should be I420 here

@@ +1544,3 @@
         bpp = 16;
+        I420 = 1;
+      case GST_MAKE_FOURCC ('I', '4', '2', '0'):

You can use mediatype->subtype for this

--- Comment #4 from Andoni Morales <ylatuya at gmail.com> 2010-08-29 23:40:33 UTC ---
Review of attachment 169011:
 --> (https://bugzilla.gnome.org/review?bug=628258&attachment=169011)

::: sys/dshowvideosink/dshowvideofakesrc.cpp
@@ -171,3 +174,3 @@
         srcstride = GST_ROUND_UP_4 ( GST_ROUND_UP_2 (vh->rcSource.right) / 2);
       else {
-        if (component == 1)
+        if (I420) {

In line 160, so should check for YV12 and I420.
Here, check the format using the 'fourcc' variable.

::: sys/dshowvideosink/dshowvideofakesrc.h
@@ +24,3 @@
 #include <gst/gst.h>
+
+bool I420;

The 'subtype' variable should be used here.

::: sys/dshowvideosink/dshowvideosink.cpp
@@ +1433,3 @@
+            "format", GST_TYPE_FOURCC, GST_MAKE_FOURCC ('Y', 'V', '1', '2'),
NULL);
+    caps = gst_caps_new_simple ("video/x-raw-yuv", 
+  else if (IsEqualGUID (mediatype->subtype, MEDIASUBTYPE_I420))

The fourcc should be I420 here

@@ +1544,3 @@
         bpp = 16;
+        I420 = 1;
+      case GST_MAKE_FOURCC ('I', '4', '2', '0'):

You can use mediatype->subtype for this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.