[gstreamer-bugs] [Bug 623121] [queue2] downloaded areas of the media are not exposed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623121
  GStreamer | gstreamer (core) | git

--- Comment #10 from Philippe Normand <phil at base-art.net> 2010-08-31 12:37:26 UTC ---
(In reply to comment #9)
> Review of attachment 169148 [details]:
> 
> ::: gst/gstquery.c
> @@ +1304,3 @@
> +  gst_structure_id_set (structure, GST_QUARK (BUFFERING_RANGES),
> +      G_TYPE_VALUE_ARRAY, ranges_copy, NULL);
> +  g_value_array_free (ranges_copy);
> 
> Why do you copy the array twice? One time manually and one time with
> gst_structure_id_set()
> 

Heh, yeah sorry ;) Will be fixed in next iteration of the patch.

> @@ +1329,3 @@
> +  value = gst_structure_id_get_value (structure, GST_QUARK
> (BUFFERING_RANGES));
> +  ranges = g_value_array_copy ((GValueArray *) g_value_get_boxed (value));
> +  return ranges;
> 
> For other queries, events, etc the API usually is, that the parsed data is
> owned by the query and only valid as long as the query is there.

Well the other queries handle simpler types, at least from what I read in
gstquery.c... I don't really see how to avoid the copy here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.