[gstreamer-bugs] [Bug 435120] cairosvgoverlay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=435120
  GStreamer | gst-plugins-bad | git

olivier.aubert changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166265|0                           |1
        is obsolete|                            |

--- Comment #9 from olivier.aubert at liris.cnrs.fr 2010-08-31 21:55:04 UTC ---
Created an attachment (id=169196)
 View: https://bugzilla.gnome.org/attachment.cgi?id=169196
 Review: https://bugzilla.gnome.org/review?bug=435120&attachment=169196

Implement rsvgoverlay element

This patch against current gst-plugins-bad adds the rsvgoverlay element to the
rsvg plugin. It offers a simple way to overlay a SVG file (or directly feed it
SVG data) to a video.

This new version addresses most comments from Sebastian review, except for the
most important  one (I assume): the non-gstreamic way of feeding SVG data. I
gave it a try, but it is not as simple as writing a video filter: data is sent
as multiple chunks, that have to be collected before being displayed. As there
is no really similar examples, it takes a lot of guessing/rummaging through
various plugins sources to achieve this. Worse, as the API evolved, there are
(I guess) multiple different ways to achieve almost the same thing...
I do not throw the towel, but I think the other changes are relevant enough to
justify to post this new version (which adds x/y properties).

That said, I will implement the data_sink approach, but would like to keep data
and filename parameters, for the sake of simplicity (from the Zen of Python:
"practicality beats purity", or in more common words, "Make simple things
simple, complex things possible"). I really think that the following pipeline:

gst-launch videotestsrc ! rsvgoverlay filename=/tmp/a.svg ! ffmpegcolorspace !
autovideosink

is more simple/readable than the more gstreamish:

gst-launch videotestsrc ! rsvgoverlay name=svg ! ffmpegcolorspace ! xvimagesink
filesrc location=/tmp/a.svg ! image/svg ! svg.data_sink

so both ways are desirable. The same is done in textoverlay/cairotextoverlay
for instance.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.