[gstreamer-bugs] [Bug 636241] Align XOverlay handling not to use deprecated methods

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636241
  GStreamer | qt-gstreamer | 0.10.31

--- Comment #3 from Marco Ballesio <gibrovacco at gmail.com> 2010-12-01 19:49:55 UTC ---
(In reply to comment #1)
> Review of attachment 175647 [details]:
> 
> In xoverlay.h:
> I'd prefer not to include <QtGui/QWidget>, but <QtGui/qwindowdefs.h> to keep
> the QtGui intrusion as minimal as possible. Note that this class is in the main
> QtGStreamer library which does not depend on QtGui (although we may want to
> reconsider that...)

Actually I was searching for that exact library but then I followed the example
at:

http://www.gstreamer.net/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstxoverlay.html

btw I like much more the modification you suggested, so now it's there.

> 
> In xoverlay.cpp:
> The cast is plain wrong. The C method takes a gpointer, which means that:
> On X11 (where WId is ulong), it should be reinterpret_cast<gpointer>'ed
> On Mac (where WId is int or long), it should be reinterpret_cast<gpointer>'ed
> again.
> On Windows (where WId is HWND, which in turn is a void*), it should be passed
> without a cast (or maybe static_cast<HWND> for safety?)
> 

Actually, looking at the example of above we should not need any cast at all.
If you're extra-sure we need it maybe we've a bug in the example documentation
of GstXOverlay (I've never tried it outside Ubuntu so maybe we'll need some
Windows/MacOS users to confirm).

> Btw, I'm not really sure if on X11 and mac you are supposed to cast the
> gpointer to ulong/long/int or pass a pointer to it.
> 
> In videowidget.cpp:
> The #ifdef should be removed and the WId should be passed as is, without a
> cast.

Done

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.