[gstreamer-bugs] [Bug 402562] [gst_parse_launch] Requesting pads but not releasing them

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=402562
  GStreamer | gstreamer (core) | git

--- Comment #8 from David Schleef <ds at schleef.org> 2010-12-05 03:12:17 UTC ---
I think the problem here is that gst_element_dispose() calls the internal
function instead of calling ->release_pad().  Unfortunately, this makes lots of
element fail, probably because they're not expecting release_pad() to be called
so late in the cleanup process.


@@ -2916,7 +2919,10 @@ gst_element_dispose (GObject * object)
   /* first we break all our links with the outside */
   while (element->pads && element->pads->data) {
     /* don't call _remove_pad with NULL */
-    gst_element_remove_pad (element, GST_PAD_CAST (element->pads->data));
+    if (oclass->release_pad)
+      (oclass->release_pad) (element, GST_PAD_CAST (element->pads->data));
+    else
+      gst_element_remove_pad (element, GST_PAD_CAST (element->pads->data));
   }
   if (G_UNLIKELY (element->pads != NULL)) {
     g_critical ("could not remove pads from element %s",

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.