[gstreamer-bugs] [Bug 636827] New: Usage of gst_caps_interset where gst_caps_can_intersect was intended?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636827
  GStreamer | gst-plugins-base | unspecified

           Summary: Usage of gst_caps_interset where
                    gst_caps_can_intersect was intended?
    Classification: Desktop
           Product: GStreamer
           Version: unspecified
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: g.stark at realdigitalmedia.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


In commit f5469d42deb05fcc32f1226ff6c25d9dd978dc43 gst_caps_intersect was
changed to gst_caps_can_intersect however on line 2090, gst_caps_intersect was
used:


-  intersection = gst_caps_intersect (xvimagesink->xcontext->caps, caps);
-  GST_DEBUG_OBJECT (xvimagesink, "intersection returned %" GST_PTR_FORMAT,
-      intersection);
-  if (gst_caps_is_empty (intersection))
+  if (!gst_caps_intersect (xvimagesink->xcontext->caps, caps))
     goto incompatible_caps;

-  gst_caps_unref (intersection);
-

I believe this is leading to a leak of the resulting caps when there is an
intersection.  I can supply some valgrind results if necessary.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.