[gstreamer-bugs] [Bug 636753] pbutils function to map (container) caps to filename extension

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636753
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |slomo at circular-chaos.org
     Ever Confirmed|0                           |1

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-11 16:42:30 UTC ---
* You say that the caps should be fixed but I think you mean simple (i.e. one
structure) caps, like in your testcase. You should also add a
g_return_val_if_fail(GST_CAPS_IS_SIMPLE(caps), NULL) at the beginning of the
function
* If you check for subset from both directions you can simply use
gst_caps_can_intersect(). It's also much faster. IMHO checking for an
intersection is good enough here
* IMHO there should be no lower-ranked typefinder that has extensions while a
high-ranked typefinder does not have any. That would be a bug in the
high-ranked typefinder.
* Your testcase exposes a small problem already. Usually MPEG 1 Layer 2 will
use mp2 as extension, not mp3. (and use fail_unless_equals_string())

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.