[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=586570
  GStreamer | gst-plugins-base | git

--- Comment #32 from Leo Singer <lsinger at caltech.edu> 2010-12-15 23:32:16 UTC ---
Doh!

It turns out that I was having an issue with a stream whose buffer offsets
started from a value greater than zero.  I had forgotten to subtract off the
initial offset in the if statement shown here:

diff --git a/gst/audioresample/gstaudioresample.c
b/gst/audioresample/gstaudioresample.c
index 4623179..93ab0ea 100644
--- a/gst/audioresample/gstaudioresample.c
+++ b/gst/audioresample/gstaudioresample.c
@@ -1052,7 +1052,7 @@ gst_audio_resample_process (GstAudioResample * resample,
GstBuffer * inbuf,
     {
       guint num, den;
       resample->funcs->get_ratio (resample->state, &num, &den);
-      if (resample->next_in_offset + in_len >= filt_len / 2)
+      if (resample->next_in_offset - resample->in_offset0 + in_len >= filt_len
/ 2)
         out_processed =
             gst_util_uint64_scale_int_ceil (resample->next_in_offset -
             resample->in_offset0 + in_len - filt_len / 2, den,

I'll incorporate this into the appropriate patch in that tarball, continue
testing, and have another reply shortly.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.