[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=586570
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
         AssignedTo|slomo at circular-chaos.org    |gstreamer-bugs at lists.source
                   |                            |forge.net
   Target Milestone|HEAD                        |0.10.32

--- Comment #35 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-17 18:37:38 UTC ---
commit 5bfe1baab393d2a0b16329abda1bd1a7f38d4aec
Author: Leo Singer <leo.singer at ligo.org>
Date:   Fri Dec 17 00:49:26 2010 -0800

    audioresample: corrected buffer duration calculation to account for nonzero
initial time

    Since we calculate timestamps by:

      timestamp = t0 + (out samples) / (out rate)

    and durations by:

      duration = ((out samples) + (processed samples)) / (out rate) - timestamp

    if t0 is nonzero, this would simplify to

      duration = t0 + (processed samples) / (out rate).

    This duration is too large by the amount t0.  We should have done:

      duration = t0 + ((out samples) + (processed samples)) / (out rate) -
timestamp

    so that

      duration = (processed samples) / (out rate).


commit 25a154be5f971e86b37c6d4130176d4583625a6d
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:40:33 2010 -0800

    audioresample: changed num_gap_samples, num_nongap_samples from guint32 to
guint64 so th

commit d6d2aa44ab5c1cb1a0b83d07d3acf56a312d61a1
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:38:31 2010 -0800

    audioresample: push half a history length, instead of a full history
length, at end-of-s

commit aac8b216787083030dd41fe434e11d21c197bda4
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:34:13 2010 -0800

    audioresample: renamed count_gap, count_nongap to more descriptive
num_gap_samples, num_

commit 6832b38527fe7af96029a88d5f579eae10c51ba9
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:32:07 2010 -0800

    audioresample: replaced void* with gpointer

commit 87f242273700bfb4ea183056749c73dd9f372e8a
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:30:24 2010 -0800

    audioresample: initial filter transient discarded; unit tests passing


commit b4cd3329a96b934c227b76c6dec955190a4dc3d8
Author: Leo Singer <leo.singer at ligo.org>
Date:   Thu Dec 16 20:09:58 2010 -0800

    Revert "Revert "audioresample: Add GAP flag support""

    This reverts commit 35c76b3409dde7f2dcc8232388a47a1b99b661a7.

    Conflicts:

        gst/audioresample/gstaudioresample.c
        gst/audioresample/gstaudioresample.h

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.