[gstreamer-bugs] [Bug 636049] ximagesrc: fix remote X and off by ones

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636049
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-18 13:39:55 UTC ---
First of all, attaching the patches to the bug makes reviewing much easier :)
You can use git bz for that


I'm not sure these off-by-one changes are correct.

> if (rects[i].x + rects[i].width - 1 < ximagesrc->startx

So, if we have a rect x=0,width=2 and startx=2, there would be no overlap. The
rect would be on the pixel 0 and the pixel 1 but not on the pixel 2, where the
ximagesrc window starts. Anything I'm missing here?   (same of the
y/height/starty change)

But OTOH this looks wrong too

> rects[i].x > ximagesrc->endx

Shouldn't this be a >= instead?

And the same questions for the width/height assignment below too :)



Why is XGetSubImage slower than XGetImage btw?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.