[gstreamer-bugs] [Bug 636049] ximagesrc: fix remote X and off by ones

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636049
  GStreamer | gst-plugins-good | git

--- Comment #3 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2010-12-18 14:11:37 UTC ---
> > if (rects[i].x + rects[i].width - 1 < ximagesrc->startx
> 
> So, if we have a rect x=0,width=2 and startx=2, there would be no overlap. The
> rect would be on the pixel 0 and the pixel 1 but not on the pixel 2, where the
> ximagesrc window starts. Anything I'm missing here? 

That's right, and the test will yield (0+2-1 < 2), which is true, so the code
earlies out. Unless I'm missing your point, the case you mention seems to do as
it should.

XGetSubImage makes an extra copy (the code I've seen calls XGetImage, then
copied part of the buffer it returns). I've no idea how significant the speed
hit is.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.