[gstreamer-bugs] [Bug 631574] Add GstFilters library to gst-plugins-base
bugzilla at gnome.org
Sat Dec 18 06:53:06 PST 2010
GStreamer | gst-plugins-base | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
Ever Confirmed|0 |1
--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-18 14:53:03 UTC ---
Just some high-level comments from looking at the docs
- Why do you have all these volume/audioconvert/etc filters? Isn't this
essentially the same as a GstBinFilter with the corresponding description? I'm
not sure that these are really needed... of course they don't hurt either :)
- GstResolutionFilter should also have something to specify the PAR/DAR or to
force keeping the DAR and things like that. And the name could be improved I
guess... but I don't know a good name
- gst_filter_lock/unlock: Everywhere else in GStreamer we use macros for these
things, e.g. GST_OBJECT_LOCK(). Would be nice to change that for consistency
- GstFilter::handle_message(): please add to the documentation *which* messages
will be passed to this. Is this only for gst_filter_manager_handle_message()?
If it is, what exactly is the use case for this? An example in the
documentation would help I guess :)
- It might make sense to use GstObject as base class for GstFilter and
GstFilterManager. This way you will get a) the mutex, b) parent/childs
handling, c) floating refs
- You should add a note to the documentation that dynamic pipeline changes are
not handled in all cases yet
- gst_filter_add_standard_element() is badly named. Elements with one pad named
"sink" and one pad named "src" are not really "standard elements". More
something like filter elements, one-to-one elements, etc.
- Is gst_filter_revert_bin() possible on a filter added by
gst_filter_add_element_by_name()? If not, would such a feature be possible?
- GstMultiFilterManager says that you must not do anything with it other than
listening to signals. Is this really true? You can't call any of the
GstFilterManager interface functions?
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs