[gstreamer-bugs] [Bug 637532] New: applemedia: redundant declaration of 'parent_class'

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=637532
  GStreamer | gst-plugins-bad | git

           Summary: applemedia: redundant declaration of 'parent_class'
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lsinger at caltech.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=176680)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=176680)
Proposed patch

There are two source files in the applemedia plugin that have redundant
declaration warnings because 'parent_class' is declared both explicitly in the
source code and also by the call to GST_BOILERPLATE_FULL.

cc1: warnings being treated as errors
miovideosrc.c:88: warning: redundant redeclaration of 'parent_class'
miovideosrc.c:86: warning: previous declaration of 'parent_class' was here

and

cc1obj: warnings being treated as errors
qtkitvideosrc.m:469: warning: redundant redeclaration of 'parent_class'
qtkitvideosrc.m:89: warning: previous declaration of 'parent_class' was here


The attached patch removes the redundant declaration from both source files,
but in qtkitvideosrc.c I also moved the call to GST_BOILERPLATE_FULL above all
of the functions that make use of parent_class.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.