[gstreamer-bugs] [Bug 631574] Add GstFilters library to gst-plugins-base

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631574
  GStreamer | gst-plugins-base | git

--- Comment #11 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-12-21 20:12:55 UTC ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #7)
> > > - gst_filter_add_standard_element() is badly named. Elements with one pad named
> > > "sink" and one pad named "src" are not really "standard elements". More
> > > something like filter elements, one-to-one elements, etc.
> > hehe, well, all the elements that get added are basically filters with
> > one-to-one pads, but since this is to be used internally for a filter, it
> > doesn't really make sense to call it gst_filter_add_filter_element. I know
> > there isn't really a 'standard' but it's become a 'kind of standard' for people
> > to name their pads 'src' and 'sink'.. I'm sure if you see an element with a
> > sink pad named "my_sink_pad", you would frown during code review and tell the
> > committer to name it correctly.
> > If you have a better suggestion for the function name, let me know though, I
> > don't mind changing it.
> 
> Unfortunately I don't know a better name, sorry :) Someone else?

why not just gst_filter_add_element () or gst_filter_add_element_default ().
Imho describing the difference in the API docs is enough.

It would be nice to have a small example in the section docs for the helpers.
The purpose of the _revert_ functions is not totally clear to me (or the naming
is a bit unlucky).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.