[gstreamer-bugs] [Bug 637927] oggdemux: set headers on caps

Fri Dec 24 05:12:19 PST 2010

https://bugzilla.gnome.org/show_bug.cgi?id=637927
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-24 13:12:16 UTC ---
(In reply to comment #2)

> ::: ext/ogg/gstoggdemux.c
> @@ +1741,3 @@
> +    GST_BUFFER_FLAG_SET (buffer, GST_BUFFER_FLAG_IN_CAPS);
> +    g_value_init (&value, GST_TYPE_BUFFER);
> +    gst_value_set_buffer (&value, buffer);
> 
> You could use gst_value_take_buffer() here to prevent copying the data twice

Of course this is wrong (the copying) and really doesn't matter here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.