[gstreamer-bugs] [Bug 635231] baseaudiosink: protect against ringbuffer disappearing while in a query

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=635231
  GStreamer | gst-plugins-base | unspecified

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |wim.taymans at gmail.com
         Resolution|                            |FIXED

--- Comment #4 from Wim Taymans <wim.taymans at gmail.com> 2010-12-29 11:30:14 UTC ---
commit 60ff7c0eb475f80e8a0e767f432a55485aba0d75
Author: Havard Graff <havard.graff at tandberg.com>
Date:   Thu Nov 25 17:01:04 2010 +0100

    baseaudiosink: protect against ringbuffer disappearing while in a query

    Observed a case where the sink went to null-state during the query,
    hence the ringbuffer-pointer was NULL, causing a crash.

    Moving the ringbuffer-check code until after the query, and hold the
    lock during the check and while using the spec-values. It should not matter
    to the query wether the ringbuffer is present or not, and it actually
    gets a time bit more time to get the ringbuffer set up in this case!

    Fixes #635231

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.