[gstreamer-bugs] [Bug 607798] x264enc needs updating to support new features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607798
  GStreamer | gst-plugins-ugly | git

Robert Swain <robert.swain> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robert.swain at gmail.com

--- Comment #7 from Robert Swain <robert.swain at gmail.com> 2010-02-03 12:32:48 UTC ---
I think we need to check the property ranges too as, for example, I'm pretty
sure b-frames and refs should allow 0-16 rather than 0-4 and 0-12 respectively.

Maybe when adding new options we should add them as enums or ints using
validation even if they are boolean initially to avoid having to switch from
boolean to int later.

For existing booleans that are now ints in x264, we will have to break gst's
API a little so we should find an appropriate point at which we can do this.

As regards the presets using the x264 API, I think not being allowed to string
together multiple presets is fine because in the x264 API, presets are only
specifying quality options. We can manage other GStreamer presets that exert
additional limitations on options using other parts of the x264 API. Using the
speed/quality trade-off presets from x264 itself will at least leverage
upstream maintenance for that.

I hope more comments and discussion will ensue. I'm happy to code this stuff if
we can agree on what is needed to be current/flexible for x264 while not
breaking things for people upgrading on the GStreamer side.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.