[gstreamer-bugs] [Bug 609107] [qtdemux] Unknown atoms should also be skipped when looking for moov

Fri Feb 5 12:49:39 PST 2010

https://bugzilla.gnome.org/show_bug.cgi?id=609107
  GStreamer | gst-plugins-good | 0.10.18

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #153096|none                        |reviewed
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-02-05 20:49:37 UTC ---
Review of attachment 153096:
 --> (https://bugzilla.gnome.org/review?bug=609107&attachment=153096)

Haven't really tested, but the change looks simple and from the code seems
good. One thing you forgot is to reset the variable when qtdemux is set to
READY.

Nitpick: you don't need to use "== TRUE"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.