[gstreamer-bugs] [Bug 610187] New: [xvimagesink] making X calls with x_lock unlocked

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=610187
  GStreamer | gst-plugins-good | 0.10.x

           Summary: [xvimagesink] making X calls with x_lock unlocked
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tommi.komulainen at iki.fi
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=153956)
 View: https://bugzilla.gnome.org/attachment.cgi?id=153956
 Review: https://bugzilla.gnome.org/review?bug=610187&attachment=153956

Make X calls with x_lock locked

Saw the following assertion a couple times.

../../src/xcb_lock.c:77: _XGetXCBBuffer: Assertion `((int) ((xcb_req) -
(dpy->request)) >= 0)' failed.

Can't get better backtrace as attaching gdb to the process manages to freeze
the whole device - possibly self inflicted problem, nevermind that.

Anyway, according to google that assertion could suggest threading problem and
reading the code I noticed a few potential places where X calls are made
without x_lock held and without any comments clarifying why it would be safe to
do so.

Take with grain of salt, I haven't tried building yet as I'm missing build
dependencies :-/

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.