[gstreamer-bugs] [Bug 605930] [shave] common/shave not existing yet when configure checks need it

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=605930
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.26

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-01-06 17:39:17 UTC ---
I'm guessing SHAVE_INIT is changing the configure test environment (CC etc.) to
use shave, but common/shave is only created later via AC_OUTPUT, so all checks
that invoke a compiler will fail.

Moving SHAVE_INIT after AG_GST_CHECK_CHECKS fixes this for me:

commit 0c1e45acf32be3f6afeb65d26b43bfd8a90bb88c
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Jan 6 17:35:07 2010 +0000

    configure: move SHAVE_INIT behind all checks

    Move SHAVE_INIT behind all other checks, in particular AG_GST_CHECK_CHECKS.
    This should fix problems with header checking and checking for localtime_r,
    which causes compilation errors with clean checkouts where common/shave has
    not been created yet when those checks are run. It seems like SHAVE_INIT
    changes the environment so that checks depending on a compiler need shave
    to exist at that point, which will fail if AC_OUTPUT hasn't created it
    yet.

    Fixes #605930.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.