[gstreamer-bugs] [Bug 606949] New: [playbin2] verify type of volume property before using it

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=606949
  GStreamer | gst-plugins-base | git

           Summary: [playbin2] verify type of volume property before using
                    it
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: t.i.m at zen.co.uk, wim.taymans at gmail.com,
                    christian.thalinger at gmail.com
        Depends on: 606878
      GNOME target: ---
     GNOME version: ---


This happens because apexsink has (had) a volume property of type int and
playsink doesn't check for the type and just assumes it's of type gdouble, so
things may crash in g_object_set() because the vararg function arguments don't
line up any longer if sizeof(double)!=sizeof(int).


+++ This bug was initially created as a clone of Bug #606878 +++

To reproduce bug I just have to use the apexsink as musicaudiosink and press on
the volume symbol in Rhythmbox.  It also crashes when doing:

$ pstack core
core 'core' of 15541:    rhythmbox
-----------------  lwp# 1 / thread# 1  --------------------
 c9a648ef strchr   (807c1f0, 3fbe8bb1, 8679388, 1) + f
 c8473700 g_object_set_valist (90a1220, c346923c, 8045df8, c84742e0) + 22c
 c847430d g_object_set (90a1220, c346923c, d72571db, 3fbe8bb1, 0, 3c) + 39
 c344a926 gst_play_sink_set_volume (8eac018, d72571db, 3fbe8bb1, c3443d1a) + d2

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.