[gstreamer-bugs] [Bug 608213] add some more debugging macros to gstclock.h and gstbuffer.h

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=608213
  GStreamer | gstreamer (core) | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152369|none                        |reviewed
             status|                            |

--- Comment #1 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-01-28 15:14:01 UTC ---
Review of attachment 152369:
 --> (https://bugzilla.gnome.org/review?bug=608213&attachment=152369)

Some of the doc additions are fine with me. Not sure about the extra macros.
Should not hurt.

::: gst/gstbuffer.h
@@ +212,3 @@
+ *
+ * printf("%" GST_BUFFER_BOUNDARIES_FORMAT "\n",
GST_BUFFER_BOUNDARIES_ARGS(buf));
+ *

could you change this into:
|[
printf("%" GST_BUFFER_BOUNDARIES_FORMAT "\n", GST_BUFFER_BOUNDARIES_ARGS(buf));
]|
Thats gtk-doc shortcut syntax for
<informalexample><programmlisting>...</programmlisting></informalexample>

::: gst/gstclock.h
@@ +209,3 @@
+ * #GstClockTime value in h:m:s format.  Use GST_TIME_ARGS to construct
+ * the matching arguments.
+ *

You would use "Use GST_TIME_ARGS() to construct" to make it xref'ed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.