[gstreamer-bugs] [Bug 608651] New: dshowvideosink.cpp crash

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=608651
  GStreamer | gst-plugins-bad | 0.10.17

           Summary: dshowvideosink.cpp crash
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.17
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: dhoyt at llnl.gov
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=152704)
 View: https://bugzilla.gnome.org/attachment.cgi?id=152704
 Review: https://bugzilla.gnome.org/review?bug=608651&attachment=152704

dshowvideosink.cpp patch

dshowvideosink will crash sometimes if it encounters an unknown format.
According to MSDN: "In any function that receives an AM_MEDIA_TYPE parameter,
always validate the values of cbFormat and formattype before dereferencing the
pbFormat member."

I attached a patch and an example video (dnxhd test from FFmpeg) that causes
gst to crash on windows using this sink.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.