[gstreamer-bugs] [Bug 623629] New: Reverse Playback Issue in QtDemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623629
  GStreamer | gst-plugins-good | git

           Summary: Reverse Playback Issue in QtDemux
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ved.kpl at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=165305)
 View: https://bugzilla.gnome.org/attachment.cgi?id=165305
 Review: https://bugzilla.gnome.org/review?bug=623629&attachment=165305

Patch: The patch basically avoids aligning the reference stream during the
alignment of other streams, since the reference stream is already aligned
before.

During reverse playback, the qtdemux goes past two keyframes instead of one in
gst_qtdemux_seek_to_previous_keyframe (). This results in sending a keyframe in
between the two keyframe boundaries (i.e when sending from a keyframe point in
ascending timestamp values).

Expected: (where K is a keyframe and P non-keyframe)
K3-P31-P32-P33-K2-P21-P22-P23-K1-P11-P12-P13

As Seen Currently:
K3-P31-P32-P33-K1-P11-P12-P13-K2-P21-P22-P23

This issue is mostly observed for timestamps that are not rational (eg. 24 fps,
30 fps, 29.97 fps), due to the conversion from index to position and
vice-versa.

Kindly go through the patch attached to see if it's fine. 
I have tested it with a few files and it seemed to work fine at my end.

Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.