[gstreamer-bugs] [Bug 607798] x264enc needs updating to support new features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607798
  GStreamer | gst-plugins-ugly | git

--- Comment #58 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2010-07-09 14:08:53 UTC ---
(In reply to comment #47)
> Created an attachment (id=165504)
 View: https://bugzilla.gnome.org/attachment.cgi?id=165504
 Review: https://bugzilla.gnome.org/review?bug=607798&attachment=165504

> Use x264 APIs to better configure libx264 through x264enc
> 
> Fix a couple of compile bugs. I think the g_string_assign () in _set_property
> () is OK but would welcome verification.

The g_string_assign looks OK.

A few other "nitpicks", in gst_x264_enc_init_encoder:

* there are several exit points (return) that bail out while GST_OBJECT_LOCK()
is taken.  That should at least then be unlocked, and it might be considered if
re-flowing those exits to some ERROR section at end is cleaner (or maybe not).

* there is twice a debug message "Failed to parse option string", where one
parses a user-provided one and another an internally generated one.  While the
message is correct in both cases, a slightly different message for each case
might be more beneficial (as debug messages go).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.