[gstreamer-bugs] [Bug 594504] Need a GType of "Date AND Time AND Timezone"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=594504
  GStreamer | gstreamer (core) | git

--- Comment #46 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-07-18 11:29:46 UTC ---
First the nitpicking:

> taglist: Add datetime get functions

 - is missing Since: markers in gtk-doc chunks


> Adds a datetime functions to gstvalue

 - -> gstvalue: add datetime functions

 - has Since: markers with glib version (2.26)

 - GST_TYPE_DATE_TIME has no Since markers

 - do we need to expose the _compare() function?
   I think we should keep it private/internal for now.

 - I assume when GstDateTime is serialised, we now
  get "(GstDateTime)2010...." right? I wonder if we should
  add a mnemonic without prefix ("datetime"?) so we
  don't have problems with "GDateTime" vs. "GstDateTime"
  later when switching GstDateTime to GDateTime (if it
  ever happens). Of course we can just leave it at "(GstDateTime)"
  and add some special casing later.


> gststructure: Adds datetime getter function

Why do we need a datetime getter for GstStructure?


> gstvalue: Adds tests for datetime

Could you fix up the two chunks at the bottom that gst-indent thinks it needs
to re-indent? Just split them into to GValue foo = { ... }; lines.


> gstdatetime: Adds GstDateTime

 - why do we have gst_date_time_get_dmy(), but
   for the time fields it's _get_hour(), get_minute()
   etc.? Instead of one function?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.