[gstreamer-bugs] [Bug 623491] make *_get_type() thread safe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623491
  GStreamer | gstreamer (core) | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166214|none                        |committed
             status|                            |

--- Comment #10 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-07-21 20:41:35 UTC ---
(From update of attachment 166214)
This I'll commit, but I'll avoid some of the type -> _type renames to keep the
diff minimal. Hope there wasn't a reason for that.

> For the tests/check, I think that depends on how you define "broken". For thread safe problems, it's really hard to prove it's broken. but I'd say it's as broken as any other code with static variables. Has anyone noticed a problem with the non-thread-safe _get_type()?

These tests are for the most part all run in a single thread, that's why I said
it wasn't strictly needed. Never seen or heard of a failure related to this on
the build bots or elsewhere. But it doesn't cost us anything to fix it up I
guess.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.