[gstreamer-bugs] [Bug 614296] [basetransform] Try suggestion on bad pad alloc

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=614296
  GStreamer | gstreamer (core) | git

--- Comment #9 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-07-26 18:03:46 UTC ---
(In reply to comment #8)
> Review of attachment 157983 [details]:
> 
> ::: libs/gst/base/gstbasetransform.c
> @@ +1654,3 @@
> +            /* do a little fixation of our own
> +             * Ideally, if the pad has a fixate function, we should use it,
> +             * but we don't have how to know */
> 
> The end of the comment sounds weird.

Fixed this.

> 
> @@ +1667,3 @@
> +             * renegotiation */
> +            gst_structure_foreach (gst_caps_get_structure (caps, 0),
> +                fixate_from_last_caps, gst_caps_get_structure (allowed, 0));
> 
> So if you don't do this, you end up with e.g. framerate=0?
> Is the '0' framerate caused because behind the scenes
> gst_structure_fixate_field_nearest_int() is called? 
> 
> Would it make sense to call:
>  allowed = gst_base_transform_find_transform(trans, pad. caps);
> instead of most of the code here.

Not really, because you need a fixed caps on one size, and we don't have it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.