[gstreamer-bugs] [Bug 413942] [wavparse] undetected dts-in-wav

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=413942
  GStreamer | gst-plugins-good | 0.10.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-06-11 20:25:32 UTC ---
(In reply to comment #6)
> Created an attachment (id=156941)
 View: https://bugzilla.gnome.org/attachment.cgi?id=156941
 Review: https://bugzilla.gnome.org/review?bug=413942&attachment=156941

> DTS typefind function patch (gst-plugins-base)
> 
> I found this old bug while preparing the DTS typefind function patch.
> 
> This patch doesn't recognize syncwords in the middle of data. But improving it
> is trivial.

Hi, thanks for the patch and sorry we didn't get to it sooner. I implemented
something a bit more elaborate so we can typefind this with more confidence.

This should fix the wavparse part (of course we now run all typefinders on the
first buffer, which isn't ideal, but shouldn't be too bad given that buffers
are quite small and usually the typefinders have already been inited and used
to typefind the .wav file in the first place).

commit 754f3a315ba37a523cbe114614cb32d666c02abe
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Fri Jun 11 20:50:23 2010 +0100

    wavparse: use typefind functions to check if PCM data contains dts stream

    Use new dts audio typefinder from -base to check if the PCM data
    contains a dts stream. This way we recognise more varieties more
    reliably and also detect the dts stream if there isn't a frame
    sync right at the start of the data.

    Fixes #413942.

commit 12ec2c3d6d3f150e01a08c7455c22b33357d642d
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Fri Jun 11 20:47:22 2010 +0100

    wavparse: set buffer offsets before using the buffer for the first time

    gst_type_find_helper_for_buffer() will need the correct offset
    set on the buffer (ie. 0) and not the byte offset we started
    pulling the data from.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.