[gstreamer-bugs] [Bug 611690] AG_GST_SET_ERROR_{C|CXX}FLAGS: allow custom warning flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611690
  GStreamer | common | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
            Summary|Allow custom warning flags  |AG_GST_SET_ERROR_{C|CXX}FLA
                   |                            |GS: allow custom warning
                   |                            |flags
     Ever Confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-03 23:34:28 UTC ---
> Created an attachment (id=155110)
 View: https://bugzilla.gnome.org/attachment.cgi?id=155110
 Review: https://bugzilla.gnome.org/review?bug=611690&attachment=155110

> Add AS_COMPILER_FLAGS from Swfdec
> 
> And use it to simplify code.

Not a big fan of this patch. Maybe it's me, but I don't think it actually makes
things much clearer or cleaner (apart from that, is the use of $CFLAGS in
AS_COMPILER_FLAGS correct for C++ as well?) I'd prefer it if we could do
without this.


> Created an attachment (id=155111)
 View: https://bugzilla.gnome.org/attachment.cgi?id=155111
 Review: https://bugzilla.gnome.org/review?bug=611690&attachment=155111

> Add additional-flags argument to AG_GST_SET_ERROR_CFLAGS
> 
> This allows applications to specify additional warning flags to
> AG_GST_SET_ERROR_CFLAGS() and AG_GST_SET_ERROR_CXXFLAGS() that will be
> added to the ERROR_CFLAGS.

This looks fine to me, and a good idea, but preferably without relying on the
previous patch (IMHO). Costs us but a foreach..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.