[gstreamer-bugs] [Bug 611692] Add more warning flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611692
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155116|none                        |reviewed
             status|                            |

--- Comment #28 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-05 09:27:21 UTC ---
Review of attachment 155116:
 --> (https://bugzilla.gnome.org/review?bug=611692&attachment=155116)

The common submodule change looks like an accidental git commit -a artefact.

::: gst/gstpad.c
@@ +2996,3 @@
   /* sanity check (only if caps are the same) */
+  if (G_LIKELY (newcaps == caps)
+      && G_UNLIKELY (GST_BUFFER_SIZE (*buf) < (unsigned) size))

May I suggest (unsigned int) or (guint) here instead?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.