[gstreamer-bugs] [Bug 576234] [basetransform] Suggesting non-fixed caps or no size doesn't work for upstream negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=576234
  GStreamer | gstreamer (core) | 0.10.25

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156297|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge <slomo at circular-chaos.org> 2010-03-16 19:50:48 UTC ---
Review of attachment 156297:
 --> (https://bugzilla.gnome.org/review?bug=576234&attachment=156297)

Looks good except this:

::: libs/gst/base/gstbasetransform.c
@@ +1599,3 @@
+
+        if (!gst_caps_is_fixed (sink_suggest))
+          goto not_fixed;

If the caps are not fixed after intersecting and fixating you should not error
out but instead do no upstream negotiation.

This case can happen if the upstream element is some converter for example.
Take the totem case, the sample rate would still not be fixated if
audioresample is before the capsfilter.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.