[gstreamer-bugs] [Bug 610249] [xoverlay] add set_render_rectangle() methods

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=610249
  GStreamer | gst-plugins-base | unspecified

--- Comment #20 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-24 18:10:47 UTC ---
> I never got an answer what the problem with the include is.

There are two problems here:

 - a build dependency issue: this can be fixed by
   building the video subdir before the interfaces subdir and
   adding the video includes to the audio and interfaces gir
   generation rules

 - a conceptual issue: the include results in libgstinterfaces
   conceptually depending on libgstvideo, so now libgstaudio
   (which depends on libgstinterfaces) ends up indirectly
   depending on libgstvideo, which is undesirable, to say
   the least.

> Honestly I don't like the "pass -1 for x,y,w,h to unset" part.

Well no, me neither. 0/0/0/0 would work for me too. I don't really think it
matters much. If you have a better suggestion...


> Also if x,y is used, we could use w,h instead of width and height.

Yes we could, but why garble argument names for no good reason? (The original
patch should've used 'rectangle' instead of 'rect' as well IMHO, but it didn't
seem worth bringing it up ;)).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.